Lior Vernia has posted comments on this change. Change subject: webadmin: Warn when importing a data domain to a DC that doesn't support ......................................................................
Patch Set 4: (4 comments) Note that this review is mostly about the software design, I don't have much clue about the flow itself (although see the one comment in ImportStorageModelBehavior which might be important). http://gerrit.ovirt.org/#/c/36328/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java: Line 88 Line 89 Line 90 Line 91 Line 92 Are you sure you can ignore this isItemsContainDataDomains() check? In what situations did it return true? Line 138: (item.getRole() == StorageDomainType.ISO || item.getRole() == StorageDomainType.ImportExport)) { Line 139: return true; Line 140: } Line 141: Line 142: // Allow import of data domains only if the data center supports OVF on any domain or in the "None" data center This documentation seems incorrect. Line 143: if (item.getRole() == StorageDomainType.Data) { Line 144: return true; Line 145: } Line 146: http://gerrit.ovirt.org/#/c/36328/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java: Line 348 Line 349 Line 350 Line 351 Line 352 You seem to have duplicated a lot of the code in the two behavior subclasses. I would put most of the implementation in StorageModelBehavior, and add two abstract protected methods there - one to check if the alert should be shown, and the other to retrieve the correct error message (as far as I could tell those are the differences between the classes). http://gerrit.ovirt.org/#/c/36328/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 227: Line 228: @DefaultStringValue("Data Center is uninitialized, in order to initialize add a data domain") Line 229: String dataCenterUninitializedAlert(); Line 230: Line 231: @DefaultStringValue("Data Center compatibility version does not support importing a data domain with it's entities. The imported domain will be imported without them.") This needs to be "its", not "it's". Possessive apostrophe isn't used with "it". Line 232: String dataCenterDoesntSupportImportDataDomainAlert(); Line 233: Line 234: Line 235: @DefaultStringValue("The selected domain already has an ISO domain and an export domains attached") -- To view, visit http://gerrit.ovirt.org/36328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e57dc3d2bcc8a3efb717f0261d9ca66636b463 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
