Allon Mureinik has posted comments on this change. Change subject: core: Storage validator packaging. ......................................................................
Patch Set 4: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36286/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskProfileValidator.java: Line 1: package org.ovirt.engine.core.bll.validator.storage; See Gilad's comment - this class should not be moved. Line 2: Line 3: import java.util.List; Line 4: Line 5: import org.apache.commons.lang.ObjectUtils; http://gerrit.ovirt.org/#/c/36286/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java: Line 76: */ Line 77: public ValidationResult isOsSupportedForVirtIoScsi(VM vm) { Line 78: if (!VmValidationUtils.isDiskInterfaceSupportedByOs(vm.getOs(), Line 79: vm.getVdsGroupCompatibilityVersion(), Line 80: DiskInterface.VirtIO_SCSI)) { The whitespacing is unrelated to the patch - please remove. Line 81: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED); Line 82: } Line 83: Line 84: return ValidationResult.VALID; -- To view, visit http://gerrit.ovirt.org/36286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc2a20be1ba12864b5d567d902f9245a05c374f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
