Liron Aravot has posted comments on this change. Change subject: core: Add alias and description for disk meta data ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/34163/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 356: } Line 357: Line 358: private void performDiskUpdate(final boolean unlockImage) { Line 359: if (shouldPerformMetadataUpdate()) { Line 360: updateMetaDataDescription((DiskImage) getNewDisk()); continuing the discussion for the previous patchset. imo we should lock the disk in the db, we lock the items in the db when long operation is running (vdsm operations is considered long..for example - storage domain change status when you perform different operations on it although no tasks are created). Regardless, you should change the UI in this patch to use MultipleActionsRunner, as now the update will cause the UI to get stuck till it returns from vdsm which can take up to 3 minutes and is a regression to the current behavior. Line 361: } Line 362: final Disk disk = getDiskDao().get(getParameters().getDiskId()); Line 363: applyUserChanges(disk); Line 364: -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
