Tal Nisan has uploaded a new change for review.

Change subject: webadmin: Fix ClassCastException in AsyncDataProvier, 
DataCenterGuideModel
......................................................................

webadmin: Fix ClassCastException in AsyncDataProvier, DataCenterGuideModel

Due to a change introduced in patch 27578 queries that once returned an
ArrayList are now returning LinkedList which resulted in a
ClassCastException making the data center guide dialogs stuck in the process

Change-Id: I7007e30fbd579b1055f8bfd1da558b723965a6cd
Signed-off-by: Tal Nisan <tni...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/36327/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
index 40ece5d..af2f059 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
@@ -2068,7 +2068,7 @@
             {
                 if (source != null)
                 {
-                    for (IVdcQueryable item : (ArrayList<IVdcQueryable>) 
source)
+                    for (IVdcQueryable item : (List<IVdcQueryable>) source)
                     {
                         return item;
                     }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
index 4ffa1c2..c05f1db 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
@@ -132,7 +132,7 @@
     private ArrayList<StorageDomain> allStorageDomains;
     private ArrayList<StorageDomain> attachedStorageDomains;
     private ArrayList<StorageDomain> isoStorageDomains;
-    private ArrayList<VDS> allHosts;
+    private List<VDS> allHosts;
     private VDS localStorageHost;
     private boolean noLocalStorageHost;
 
@@ -235,7 +235,7 @@
                     @Override
                     public void onSuccess(Object target, Object returnValue) {
                         DataCenterGuideModel dataCenterGuideModel = 
(DataCenterGuideModel) target;
-                        ArrayList<VDS> hosts =
+                        List<VDS> hosts =
                                 ((VdcQueryReturnValue) 
returnValue).getReturnValue();
                         if (hosts == null) {
                             hosts = new ArrayList<VDS>();


-- 
To view, visit http://gerrit.ovirt.org/36327
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7007e30fbd579b1055f8bfd1da558b723965a6cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to