Arik Hadas has posted comments on this change.

Change subject: engine: Adjust console ticket commands
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/28574/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java:

Line 263:                     String otp64 = Ticketing.generateOTP();
Line 264:                     Backend.getInstance()
Line 265:                             .getResourceManager()
Line 266:                             .RunVdsCommand(VDSCommandType.SetVmTicket,
Line 267:                                     new 
SetVmTicketVDSCommandParameters(vds_id, vmid, otp64, 60, "", Guid.Empty, 
GraphicsType.SPICE)); // todo verify this
verified? if verified please remove comment
Line 268:                     log.infoFormat(
Line 269:                             "VdsEventListener.ProcessOnVmPoweringUp - 
Auto start logic, starting spice to vm - {0} ",
Line 270:                             vmid);
Line 271:                     Backend.getInstance()


http://gerrit.ovirt.org/#/c/28574/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java:

Line 10: 
Line 11: public class SetVmTicketVDSCommand<P extends 
SetVmTicketVDSCommandParameters> extends VdsBrokerCommand<P> {
Line 12: 
Line 13:     private String connectionAction = "disconnect";
Line 14:     private static final Version TICKET_USING_UPDATE_DEVICE = 
Version.v3_5; // todo configurability could be nice
shouldn't be 3.6?
Line 15: 
Line 16:     public SetVmTicketVDSCommand(P parameters) {
Line 17:         super(parameters, 
DbFacade.getInstance().getVdsDao().get(parameters.getVdsId()));
Line 18:     }


-- 
To view, visit http://gerrit.ovirt.org/28574
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62c9e29349a58156cddba1ca039cf9b7f14e610
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to