Martin Mucha has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/35793/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java: Line 10: import javax.persistence.Query; Line 11: Line 12: /** Line 13: * A shared class for all DaoFacades that use Hibernate. Note that our code does not expect to work with attached Line 14: * entities, so returned entities are detached. There is an API for working with attached entities. > "…so returned entities…" I'm not sure if that's true. I think you still can aha, so the main concern is probably not to modify db record, when someone queries entity and changes it, while it's still in persistence context. ~ the same can happen with newly persisted entity. Someone persist one, then alter it's data for some reason … Line 15: * @author lzelkha Line 16: * @param <T> Line 17: * The entity Line 18: * @param <K> -- To view, visit http://gerrit.ovirt.org/35793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia408a878fa0fa8dd8b414a60683c36d0db6d6641 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
