Vojtech Szocs has posted comments on this change.

Change subject: webadmin,userportal: Persistent client-side logging 
infrastructure
......................................................................


Patch Set 5: Verified+1

Verified in Firefox and Chrome:
* uncaught exception during application init (e.g. 
ApplicationInit#performBootstrap) is caught and logged by global exception 
handler, application still works
* uncaught exception post application init (e.g. ApplicationInit#onLogin) is 
caught and logged by global exception handler, application still works
* log statements are persisted in browser's local storage as expected

This patch can prove very useful when facing frontend issues caused by uncaught 
exceptions that used to break application behavior and/or appearance, depending 
on where/when the exception occured. With this patch applied, the risk of 
potential application behavior and/or appearance breakage is reduced, with any 
uncaught exceptions logged in browser's local storage.

For now, the only way to inspect client-side log records (including those for 
uncaught exceptions) is via browser.

In Firefox:
* Open Menu / Developer / Toggle Tools
* in Console tab, type "inspect(localStorage)" into the prompt at the bottom

In Chrome:
* Open Menu / Tools / Developer Tools
* in Resources tab, select Local Storage and click on specific origin

-- 
To view, visit http://gerrit.ovirt.org/25444
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to