Eliraz Levi has posted comments on this change. Change subject: webadmin: allowing prefix as mask staticIP conf ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/35145/8/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java: Line 13: import org.junit.runners.Parameterized; Line 14: import org.mockito.Mockito; Line 15: Line 16: @RunWith(Parameterized.class) Line 17: public class SubnetMaskValidationTest { > Same comments as in the common test. Done Line 18: Line 19: private SubnetMaskValidation validation; Line 20: Line 21: private final String mask; Line 67: validation.validate(maskInvlidPrefixFreeFormat).getSuccess()); Line 68: setupErrorMessage(false); Line 69: } Line 70: Line 71: private void setupErrorMessage(boolean isPrefixSupported) { > Note this method is only called with argument "false". But anyway, this sho Done Line 72: if (isPrefixSupported) { Line 73: Mockito.verify(validation).getBadMaskFormatMessage(); Line 74: } Line 75: else { Line 69: } Line 70: Line 71: private void setupErrorMessage(boolean isPrefixSupported) { Line 72: if (isPrefixSupported) { Line 73: Mockito.verify(validation).getBadMaskFormatMessage(); > Note you could statically import the verify method, then you won't need the Done Line 74: } Line 75: else { Line 76: Mockito.verify(validation).getBadNetmaskFormatMessage(); Line 77: } -- To view, visit http://gerrit.ovirt.org/35145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If909eda53a61bda5030c342156a01e53576e77cb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
