Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin:change Translator to interface ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/26596/11/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java: Line 9: private static final Logger logger = Logger.getLogger(EnumTranslator.class.getName()); Line 10: private static final UIConstants constants = ConstantsManager.getInstance().getConstants(); Line 11: private static final EnumTranslator INSTANCE = new EnumTranslator(); Line 12: Line 13: private Enums enums = ConstantsManager.getInstance().getEnums(); > I think this is not part of this patch. This patch replaced GWT.create(Enum OK, agreed, can be addressed later. Line 14: Line 15: private EnumTranslator() { Line 16: } Line 17: -- To view, visit http://gerrit.ovirt.org/26596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib018c1faf0c2e1ebaa81217d5e3696d9c8de20cf Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
