Liron Aravot has posted comments on this change. Change subject: core: encapsulate isLastMaster logic ......................................................................
Patch Set 11: Code-Review+1 (1 comment) please fix the javadoc comment http://gerrit.ovirt.org/#/c/28445/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 326: * In case of master domain this method decide if to move master to other domain or move pool to maintenance (since Line 327: * there is no master domain) Line 328: * Line 329: * @param lockNewMaster If true the new master domain will not be locked Line 330: */ please update the javadoc comment to indicate the change Line 331: protected boolean proceedStorageDomainTreatmentByDomainType(final StorageDomain newMaster, Line 332: final boolean lockNewMaster) { Line 333: if (newMaster == null) { Line 334: return true; -- To view, visit http://gerrit.ovirt.org/28445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbbf89d26c8c4e8f90e68bb89472bb4a6ee4518 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
