[Engine-patches] Change in ovirt-engine[master]: core: Remove deprecated StringHelper in RunVmCommandBase.

[Sharad Mishra]

Sharad Mishra has uploaded a new change for review.

Change subject: core: Remove deprecated StringHelper in RunVmCommandBase.
......................................................................

core: Remove deprecated StringHelper in RunVmCommandBase.

Replaced StringHelper with StringUtils

Change-Id: I5a9ca5490ccfd8f63f052ad0dfb6ae002cfd412f
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/7278/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
index 9d84370..3c6c562 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
@@ -4,6 +4,7 @@
 import java.util.HashMap;
 import java.util.List;
 
+import org.apache.commons.lang.StringUtils;
 import org.ovirt.engine.core.bll.job.ExecutionContext;
 import org.ovirt.engine.core.bll.job.ExecutionContext.ExecutionMethod;
 import org.ovirt.engine.core.bll.job.ExecutionHandler;
@@ -30,7 +31,6 @@
 import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
 import 
org.ovirt.engine.core.common.vdscommands.VmMonitorCommandVDSCommandParameters;
 import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.compat.StringHelper;
 import org.ovirt.engine.core.dal.dbbroker.DbFacade;
 import org.ovirt.engine.core.utils.log.Log;
 import org.ovirt.engine.core.utils.log.LogFactory;
@@ -177,7 +177,7 @@
                 return;
             } else {
                 String compression_enabled = "on";
-                if (StringHelper.EqOp(vds.gethost_name(), vm.getclient_ip())) {
+                if (StringUtils.equals(vds.gethost_name(), vm.getclient_ip())) 
{
                     compression_enabled = "off";
                 }
                 log.infoFormat(
@@ -290,7 +290,7 @@
         if (getVm().getlast_vds_run_on() == null || 
!getVm().getlast_vds_run_on().equals(getCurrentVdsId())) {
             getVm().setlast_vds_run_on(getCurrentVdsId());
         }
-        if (!StringHelper.isNullOrEmpty(getVm().gethibernation_vol_handle())) {
+        if (StringUtils.isNotEmpty(getVm().gethibernation_vol_handle())) {
             HandleHibernatedVm(getActionType(), true);
             // In order to prevent a race where VdsUpdateRuntimeInfo saves the 
Vm Dynamic as UP prior to execution of
             // this method (which is a part of the cached VM command,


--
To view, visit http://gerrit.ovirt.org/7278
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a9ca5490ccfd8f63f052ad0dfb6ae002cfd412f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches