Martin Mucha has posted comments on this change. Change subject: userportal,webadmin: moved duplicate UICommand creation to static factory methods ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/33317/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java: Line 274: getCommands().add(tempVar); Line 275: } Line 276: } else { Line 277: getHosts().setItems(hosts, Linq.firstOrDefault(hosts)); Line 278: getCommands().add(UICommand.createDefaultOkUiCommand("OnMigrate", parentModel)); > Need to add //$NON-NLS-1$ here, findbugs is complaining. sorry about that, DONE. Line 279: getCommands().add(UICommand.createCancelUiCommand("Cancel", parentModel)); Line 280: } Line 281: } Line 282: -- To view, visit http://gerrit.ovirt.org/33317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b3b1344b1a3819e58de4db5093106bedf5291e6 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
