[Engine-patches] Change in ovirt-engine[master]: core: Remove deprecated StringHelper in InstallerMessages.

[Sharad Mishra]

Sharad Mishra has uploaded a new change for review.

Change subject: core: Remove deprecated StringHelper in InstallerMessages.
......................................................................

core: Remove deprecated StringHelper in InstallerMessages.

Replaced StringHelper with StringUtils

Change-Id: I5f9a2fd6047a30203c2efca357fefd93897d5992
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/7270/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
index 167c6ec..ed27468 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
@@ -1,8 +1,8 @@
 package org.ovirt.engine.core.bll;
 
+import org.apache.commons.lang.StringUtils;
 import org.ovirt.engine.core.common.AuditLogType;
 import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.compat.StringHelper;
 import org.ovirt.engine.core.compat.backendcompat.XmlDocument;
 import org.ovirt.engine.core.compat.backendcompat.XmlNode;
 import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector;
@@ -18,7 +18,7 @@
     }
 
     public void AddMessage(String message) {
-        if (StringHelper.isNullOrEmpty(message)) {
+        if (StringUtils.isEmpty(message)) {
             return;
         }
         String[] msgs = message.split("[\\n]", -1);
@@ -29,7 +29,7 @@
             return;
         }
 
-        if (!StringHelper.isNullOrEmpty(message)) {
+        if (StringUtils.isNotEmpty(message)) {
             if (message.charAt(0) == '<') {
                 try {
                     parseMessage(message);
@@ -63,23 +63,23 @@
             }
 
             if ((node.Attributes.get("component") != null)
-                    && 
(!StringHelper.isNullOrEmpty(node.Attributes.get("component").getValue()))) {
+                    && 
(StringUtils.isNotEmpty(node.Attributes.get("component").getValue()))) {
                 sb.append("Step: " + 
node.Attributes.get("component").getValue());
             }
 
             if ((node.Attributes.get("message") != null)
-                    && 
(!StringHelper.isNullOrEmpty(node.Attributes.get("message").getValue()))) {
+                    && 
(StringUtils.isNotEmpty(node.Attributes.get("message").getValue()))) {
                 sb.append("; ");
                 sb.append("Details: " + 
node.Attributes.get("message").getValue());
                 sb.append(" ");
             }
 
             if ((node.Attributes.get("result") != null)
-                    && 
(!StringHelper.isNullOrEmpty(node.Attributes.get("result").getValue()))) {
+                    && 
(StringUtils.isNotEmpty(node.Attributes.get("result").getValue()))) {
                 sb.append(" (" + node.Attributes.get("result").getValue() + 
")");
             }
             AuditLogableBase logable = new AuditLogableBase(_vdsId);
-            logable.AddCustomValue("Message", 
StringHelper.trimEnd(sb.toString(), ' '));
+            logable.AddCustomValue("Message", 
StringUtils.stripEnd(sb.toString(), " "));
             AuditLogDirector.log(logable, logType);
         }
     }


--
To view, visit http://gerrit.ovirt.org/7270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f9a2fd6047a30203c2efca357fefd93897d5992
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches