Juan Hernandez has posted comments on this change.
Change subject: core: fixing imports.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/PoolConditionFieldAutoCompleter.java
Line 1: package org.ovirt.engine.core.searchbackend;
Line 2:
Line 3: import org.ovirt.engine.core.compat.*;
You can also remove this line ...
Line 4: import org.ovirt.engine.core.common.businessentities.VmPoolType;
Line 5:
Line 6: public class PoolConditionFieldAutoCompleter extends
BaseConditionFieldAutoCompleter {
Line 7: public PoolConditionFieldAutoCompleter() {
Line 32: }
Line 33:
Line 34: @Override
Line 35: public IConditionValueAutoCompleter
getFieldValueAutoCompleter(String fieldName) {
Line 36: IConditionValueAutoCompleter retval = null;
... if you replace this with "TYPE".equals(fieldName) as discussed in
http://gerrit.ovirt.org/7228
Line 37: if (StringHelper.EqOp(fieldName, "TYPE")) {
Line 38: retval = new EnumValueAutoCompleter(VmPoolType.class);
Line 39: } else {
Line 40: }
--
To view, visit http://gerrit.ovirt.org/7225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I495e706a5f2b2b199021470c4748198aaa7f2011
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
