Tal Nisan has posted comments on this change. Change subject: core: disable illegal operations on a pooled VM ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35457/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 278: if (updateReadOnlyRequested()) { Line 279: if(getVm().getStatus() != VMStatus.Down && vmDeviceForVm.getIsPlugged()) { Line 280: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); Line 281: } Line 282: if (!validateVmPoolProperties()) { Why is it needed here if it's already called from line 176? Not to mention that in the CDA it's run twice Line 283: return false; Line 284: } Line 285: return validate(diskValidator.isReadOnlyPropertyCompatibleWithInterface()); Line 286: } -- To view, visit http://gerrit.ovirt.org/35457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3a6e1542f3ef4fb78f074b62e854a4907dfbca6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
