Maor Lipchuk has posted comments on this change. Change subject: core: Add alias and description for disk meta data ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/34163/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java: Line 104: Line 105: setSucceeded(true); Line 106: } Line 107: Line 108: private void updateMetaDataDescription() { > I don't think that's correct - Moved the logic to updateDiskCommand Line 109: DiskImage diskImage = (DiskImage) disk; Line 110: SetVolumeDescriptionVDSCommandParameters vdsCommandParameters = Line 111: new SetVolumeDescriptionVDSCommandParameters(getVm().getStoragePoolId(), Line 112: diskImage.getStorageIds().get(0), Line 126: AuditLogDirector.log(auditLogableBase, AuditLogType.UPDATE_DESCRIPTION_FOR_DISK_FAILED); Line 127: } Line 128: } Line 129: Line 130: private String getJsonDiskDescription() { > why the behavior here is different than the AddImageFromScratch command? I will change this to also indicate the audit log as part of updateMetaDataDescription method Line 131: try { Line 132: return ImagesHandler.getJsonDiskDescription(getParameters().getDiskInfo().getDiskAlias(), Line 133: getParameters().getDiskInfo().getDiskDescription()); Line 134: } catch (IOException e) { -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
