Allon Mureinik has posted comments on this change. Change subject: core: avoid saving duplicate records when saving LUN connections ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36212/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java: Line 36: this.portal = portal; Line 37: this.vfsType = vfsType; Line 38: this.mountOptions = mountOptions; Line 39: this.nfsVersion = nfsVersion; Line 40: this.nfsRetrans = nfsRetrans; these should also use getStringValueToSet Line 41: this.nfsTimeo = nfsTimeo; Line 42: } Line 43: Line 44: public StorageServerConnections(String connection, -- To view, visit http://gerrit.ovirt.org/36212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I997ba0fbc6e984a9e6782502c6b36b1f9a1f3d8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
