Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Persistent client-side logging infrastructure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25444/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/LocalStorageLogHandler.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/LocalStorageLogHandler.java: Line 21: private static final String LOG_HEAD_KEY = "LogHead"; //$NON-NLS-1$ Line 22: private static final String LOG_SIZE_KEY = "LogSize"; //$NON-NLS-1$ Line 23: Line 24: // Maximum number of log records to keep in underlying storage Line 25: private static final int LOG_CAPACITY = 100; > For really old browsers (like IE8) that don't support HTML5 local storage, Oh, just realized what you meant by lowering the log capacity. Good idea - in case local storage isn't supported, reduce LOG_CAPACITY to 10 or similar. Line 26: Line 27: private final ClientStorage clientStorage; Line 28: private final AddOnlyRingBuffer<String> logBuffer; Line 29: -- To view, visit http://gerrit.ovirt.org/25444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
