Alona Kaplan has uploaded a new change for review. Change subject: engine: Introducing GetAllVfsConfigByHostIdQuery ......................................................................
engine: Introducing GetAllVfsConfigByHostIdQuery The query returns all the vfs configs of the host. Change-Id: I7a8579a0356e2c2ac8cd77e149f74bc4aead6dfc Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/36203/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java new file mode 100644 index 0000000..84e7f8d --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java @@ -0,0 +1,16 @@ +package org.ovirt.engine.core.bll.network.host; + +import org.ovirt.engine.core.bll.QueriesCommandBase; +import org.ovirt.engine.core.common.queries.IdQueryParameters; + +public class GetAllVfsConfigByHostIdQuery<P extends IdQueryParameters> extends QueriesCommandBase<P> { + public GetAllVfsConfigByHostIdQuery(P parameters) { + super(parameters); + } + + @Override + protected void executeQueryCommand() { + getQueryReturnValue().setReturnValue(getDbFacade().getHostNicVfsConfigDao() + .getAllVfsConfigByHostId(getParameters().getId())); + } +} diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java new file mode 100644 index 0000000..f3ed13f --- /dev/null +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java @@ -0,0 +1,37 @@ +package org.ovirt.engine.core.bll.network.host; + +import static org.junit.Assert.assertEquals; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.util.ArrayList; +import java.util.List; + +import org.junit.Test; +import org.ovirt.engine.core.bll.AbstractQueryTest; +import org.ovirt.engine.core.common.businessentities.network.HostNicVfsConfig; +import org.ovirt.engine.core.common.queries.IdQueryParameters; +import org.ovirt.engine.core.compat.Guid; +import org.ovirt.engine.core.dao.network.HostNicVfsConfigDao; + +public class GetAllVfsConfigByHostIdQueryTest extends AbstractQueryTest<IdQueryParameters, GetAllVfsConfigByHostIdQuery<IdQueryParameters>> { + @Test + public void testExecuteQuery() { + Guid hostId = Guid.newGuid(); + IdQueryParameters paramsMock = getQueryParameters(); + when(paramsMock.getId()).thenReturn(hostId); + + HostNicVfsConfigDao vfsConfigDao = mock(HostNicVfsConfigDao.class); + when(getDbFacadeMockInstance().getHostNicVfsConfigDao()).thenReturn(vfsConfigDao); + + List<HostNicVfsConfig> vfsConfigs = new ArrayList<>(); + vfsConfigs.add(new HostNicVfsConfig()); + when(vfsConfigDao.getAllVfsConfigByHostId(hostId)).thenReturn(vfsConfigs); + + getQuery().executeQueryCommand(); + + List<HostNicVfsConfig> result = getQuery().getQueryReturnValue().getReturnValue(); + + assertEquals(vfsConfigs, result); + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 58e08fd..0f04713 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -66,6 +66,7 @@ GetNetworksByDataCenterId(VdcQueryAuthType.User), GetManagementInterfaceAddressByVmId(VdcQueryAuthType.User), GetInterfacesByLabelForNetwork, + GetAllVfsConfigByHostId, // Vm Network GetVmInterfacesByVmId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/36203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a8579a0356e2c2ac8cd77e149f74bc4aead6dfc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches