Martin Sivák has posted comments on this change. Change subject: Add scheduling filter that prevents migration to same host ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34700/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java: Line 74: if (host.getId().equals(vm.getRunOnVds())) { Line 75: log.debug("Vm '{}' already runs on host '{}', filtering host", vm.getName(), host.getName()); Line 76: messages.addMessage(host.getId(), VdcBllMessages.VAR__DETAIL__SAME_HOST.toString()); Line 77: continue; Line 78: } > since it wasn't in use.. don't remember why. can you please remove the old What old parts? Line 79: Line 80: if (!validateDestinationVdsAddress(srcVds, host)) { Line 81: log.debug("Host '{}' resolves to the same machine as host '{}', filtering out", srcVds.getName(), host.getName()); Line 82: messages.addMessage(host.getId(), VdcBllMessages.VAR__DETAIL__SAME_HOST.toString()); -- To view, visit http://gerrit.ovirt.org/34700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42021452205f3dc070388a43de92c8fd5ed6dbf2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
