Vojtech Szocs has posted comments on this change. Change subject: webadmin: Alert/Event/Task footer fix ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35857/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/EventModelProvider.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/EventModelProvider.java: Line 11: import com.google.gwt.event.shared.EventBus; Line 12: import com.google.inject.Inject; Line 13: import com.google.inject.Provider; Line 14: Line 15: public class EventModelProvider extends SearchableTabModelProvider<AuditLog, EventListModel> { +1 on moving EventListModel-related logic from SearchableTabModelProvider to this class. Line 16: Line 17: @Inject Line 18: public EventModelProvider(EventBus eventBus, Line 19: Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider) { -- To view, visit http://gerrit.ovirt.org/35857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9083319d000e66404d531c9576a28e184979f485 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
