Lior Vernia has uploaded a new change for review.
Change subject: engine: Remove compatibility check when updating reported QoS
......................................................................
engine: Remove compatibility check when updating reported QoS
This should be okay without the check even when the host is too old -
the entry should just not exist, and then be deserialized to null
(which is exactly as avoiding it altogether).
The check had only been put there because of a backwards compatibility
problem with reported QoS between 3.3 and 3.4, but towards 3.6 the
entry name was completely changed, so it can't be reported in a
non-compatible manner anymore.
Change-Id: I4bcb42b9e1a0f5c978c90d02b635ae30570a48aa
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/36183/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
index 61420d2..8681db7 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
@@ -1505,10 +1505,8 @@
addBootProtocol(networkConfig, host, iface);
}
- if
(FeatureSupported.hostNetworkQos(Collections.max(host.getSupportedClusterVersionsSet())))
{
- HostNetworkQosMapper qosMapper = new
HostNetworkQosMapper(network);
- iface.setQos(qosMapper.deserialize());
- }
+ HostNetworkQosMapper qosMapper = new HostNetworkQosMapper(network);
+ iface.setQos(qosMapper.deserialize());
}
}
--
To view, visit http://gerrit.ovirt.org/36183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bcb42b9e1a0f5c978c90d02b635ae30570a48aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
