Selvasundaram has posted comments on this change.
Change subject: engine: Gluster server peer list command
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 198: GLUSTER_VOLUME_ADD_BRICK(4019),
Line 199: GLUSTER_VOLUME_ADD_BRICK_FAILED(4020),
Line 200: GLUSTER_HOST_REMOVE_FAILED(4021),
Line 201: GLUSTER_HOST_ADD_FAILED(4404),
Line 202: GLUSTER_HOST_LIST_FAILED(4405),
I added for future use. However it is not used in the patch, I am removing it
now.
Line 203:
Line 204: USER_VDS_RESTART(41),
Line 205: USER_FAILED_VDS_RESTART(107),
Line 206: USER_VDS_START(20),
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHostEntity.java
Line 4: import org.ovirt.engine.core.common.businessentities.VDSStatus;
Line 5: import org.ovirt.engine.core.common.utils.gluster.GlusterCoreUtil;
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7:
Line 8: public class GlusterHostEntity extends IVdcQueryable {
It is a (gluster) host entity used only for in memory operation. There is no db
operations required. If you still suggest to extend from vds_static, I will do.
Line 9:
Line 10: private Guid uuid;
Line 11:
Line 12: private String hostName;
--
To view, visit http://gerrit.ovirt.org/7242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfacfdc5847e5d871da38d22b6b5efe86ea4d579
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
