Allon Mureinik has posted comments on this change. Change subject: core: Don't erroneously remove template->storage mappings ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Looked good, note a minor phrasing comment in the commit message. .................................................... Commit Message Line 5: CommitDate: 2012-08-14 18:16:51 -0400 Line 6: Line 7: core: Don't erroneously remove template->storage mappings Line 8: Line 9: If a storage domain is destroyed and a template has a disk on that SD, s/destroyed/force removed/ Line 10: the image is removed regardless of whether that image also resides on Line 11: other SDs. In the case where the template disk has been copied, the Line 12: template and images should remain intact and only the references for the Line 13: specific SD being removed should be deleted. -- To view, visit http://gerrit.ovirt.org/7192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058d160622990d2b42ccc02a61551c6f61550ade Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
