Eli Mesika has posted comments on this change. Change subject: gluster: BLL queries for volume snapshots list and count ......................................................................
Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35674/6/packaging/dbscripts/gluster_volume_snapshot_sp.sql File packaging/dbscripts/gluster_volume_snapshot_sp.sql: Line 58: Create or replace FUNCTION GetGlusterVolumeSnapshotsCountByVolumeId(v_volume_id UUID) Line 59: RETURNS SETOF BIGINT STABLE Line 60: AS $procedure$ Line 61: BEGIN Line 62: RETURN QUERY SELECT count(*) > This is required to display the no of the snapshot created for a given volu In that case I would like to have that static by adding a snapshot_count column and updating it in INSERT/DELETE *in the same SP that is doing that) We have no reason to do such expensive queries periodically , the suggested column will do the work Line 63: FROM gluster_volume_snapshots Line 64: WHERE volume_id = v_volume_id; Line 65: END; $procedure$ Line 66: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/35674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
