Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Entities for gluster volume snapshot ......................................................................
Patch Set 14: (4 comments) http://gerrit.ovirt.org/#/c/23199/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfigParam.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfigParam.java: Line 54: } Line 55: Line 56: @Override Line 57: public boolean equals(Object obj) { Line 58: if (!(obj instanceof GlusterVolumeSnapshotConfigParam)) { > null check for obj missing will do that Line 59: return false; Line 60: } Line 61: Line 62: GlusterVolumeSnapshotConfigParam config = (GlusterVolumeSnapshotConfigParam)obj; Line 60: } Line 61: Line 62: GlusterVolumeSnapshotConfigParam config = (GlusterVolumeSnapshotConfigParam)obj; Line 63: Line 64: if (!(clusterId.equals(config.getClusterId()))) { > use ObjectUtils to compare will do that Line 65: return false; Line 66: } Line 67: Line 68: if (!(volumeId.equals(config.getVolumeId()))) { http://gerrit.ovirt.org/#/c/23199/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotEntity.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotEntity.java: Line 84: } Line 85: Line 86: @Override Line 87: public boolean equals(Object obj) { Line 88: if (!(obj instanceof GlusterVolumeSnapshotEntity)) { > same comments as previous class sure. will do that Line 89: return false; Line 90: } Line 91: Line 92: GlusterVolumeSnapshotEntity snapshot = (GlusterVolumeSnapshotEntity) obj; http://gerrit.ovirt.org/#/c/23199/14/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1698: Line 1699: CREATE OR REPLACE VIEW gluster_volume_snapshots_view Line 1700: AS Line 1701: SELECT gluster_volume_snapshots.*, Line 1702: gluster_volumes.cluster_id AS cluster_id > how about returning volume name in the view? yes. thats a good suggestion as I would not need to query again for the volume name. Line 1703: FROM gluster_volume_snapshots Line 1704: INNER JOIN gluster_volumes ON gluster_volume_snapshots.volume_id = gluster_volumes.id; Line 1705: Line 1706: CREATE OR REPLACE VIEW gluster_volume_bricks_view -- To view, visit http://gerrit.ovirt.org/23199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Nishanth Thomas <nishusem...@gmail.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
