Oved Ourfali has posted comments on this change. Change subject: Use empty string instead null for empty foreman parameters ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35444/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 95: VDS vds = new VDS(); Line 96: if (dhost != null && dhg != null) { Line 97: vds.setVdsName(dhost.getName()); Line 98: vds.setHostName(dhost.getName() + "." + //$NON-NLS-1$ Line 99: (dhg.getDomainName() != null ? dhg.getDomainName() : "")); //$NON-NLS-1$ can't you use constants.empty() here as well? Line 100: } Line 101: updateModelFromVds(vds, null, false, null); Line 102: } Line 103: -- To view, visit http://gerrit.ovirt.org/35444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c95db55a56b7a81ae81876e57426fd167bc0545 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
