Tomer Saban has uploaded a new change for review.

Change subject: webadmin: Changed the new storage popup
......................................................................

webadmin: Changed the new storage popup

The new storage qos popup is now more intutive and explains
better how to use the ui(Total and read/write can't be put together).

Change-Id: I8c7f9e0ab0087888b8dd515d6edab3641e9f5adc
Bug-Url: https://bugzilla.redhat.com/1168558
Signed-off-by: Tomer Saban <tsa...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
1 file changed, 3 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/36114/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
index 3e7c1be..6c416ed 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
@@ -143,29 +143,17 @@
         {
             updateChangeability();
 
-            if (getChoiceGroupNone().equals(sender))
-            {
-                getChoiceGroupNone().setEntity(true);
-            }
-            else
+            if (!getChoiceGroupNone().equals(sender))
             {
                 getChoiceGroupNone().setEntity(false);
             }
 
-            if (getChoiceGroupTotal().equals(sender))
-            {
-                getChoiceGroupTotal().setEntity(true);
-            }
-            else
+            if (!getChoiceGroupTotal().equals(sender))
             {
                 getChoiceGroupTotal().setEntity(false);
             }
 
-            if (getChoiceGroupReadWrite().equals(sender))
-            {
-                getChoiceGroupReadWrite().setEntity(true);
-            }
-            else
+            if (!getChoiceGroupReadWrite().equals(sender))
             {
                 getChoiceGroupReadWrite().setEntity(false);
             }


-- 
To view, visit http://gerrit.ovirt.org/36114
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c7f9e0ab0087888b8dd515d6edab3641e9f5adc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to