Alon Bar-Lev has posted comments on this change. Change subject: core: Replace ANTLRv4 with JavaCC in OsInfo validation ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36082/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java: Line 17: try (FileInputStream inputStream = new FileInputStream(path)) { Line 18: OsInfoParser parser = new OsInfoParser(inputStream); Line 19: parser.parse(); Line 20: } catch (FileNotFoundException e) { Line 21: throw new RuntimeException("osinfo properties file cannot be found"); sorry for minor comments... but please add at least path to above message, and/or add e as cause. Line 22: } catch (IOException e) { Line 23: throw new RuntimeException("error while reading osinfo properties file"); Line 24: } catch (ParseException e) { Line 25: throw new RuntimeException( -- To view, visit http://gerrit.ovirt.org/36082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
