Tal Nisan has posted comments on this change. Change subject: core: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 3: (3 comments) How about adding a test that will check that adding a new disk does indeed uses it's storage domain's WAD property as default? http://gerrit.ovirt.org/#/c/35909/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java: Line 40: // Collect changed fields to update in a list. Line 41: List<String> props = ObjectIdentityChecker.GetChangedFields(oldDomain, getStorageDomain() Line 42: .getStorageStaticData()); Line 43: Line 44: // Allow change only to name & description field The comment needs to be changed to "Allow change only to name, description, comment and wipe after delete fields" Line 45: props.remove("storageName"); Line 46: props.remove("description"); Line 47: props.remove("comment"); Line 48: props.remove("wipeAfterDelete"); http://gerrit.ovirt.org/#/c/35909/3/packaging/dbscripts/storages_sp.sql File packaging/dbscripts/storages_sp.sql: Line 410: --This function is also called during installation. If you change it, please verify Line 411: --that functions in inst_sp.sql can be executed successfully. Line 412: Line 413: Create or replace FUNCTION Insertstorage_domain_static(v_id UUID, Line 414: v_storage VARCHAR(250), The indentation fix should not be a part of this patch Line 415: v_storage_name VARCHAR(250), Line 416: v_storage_description VARCHAR(4000), Line 417: v_storage_comment text, Line 418: v_storage_type INTEGER, Line 442: Line 443: Line 444: Line 445: Create or replace FUNCTION Updatestorage_domain_static(v_id UUID, Line 446: v_storage VARCHAR(250), The indentation fix should not be a part of this patch Line 447: v_storage_name VARCHAR(250), Line 448: v_storage_description VARCHAR(4000), Line 449: v_storage_comment text, Line 450: v_storage_type INTEGER, -- To view, visit http://gerrit.ovirt.org/35909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0d5a1c9158be1284ffe05d1bf1397c9113f6c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
