Tomas Jelinek has posted comments on this change. Change subject: frontend: Prevent selecting web based console clients in IE ......................................................................
Patch Set 3: (3 comments) only tiny comments, other than that seems ok http://gerrit.ovirt.org/#/c/34836/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 1564: Line 1565: @DefaultStringValue("VNC") Line 1566: String vnc(); Line 1567: Line 1568: @DefaultStringValue("SPICE-HTML5 and noVNC clients can be used only in browsers other than Internet Explorer. " + I'd say a bit better phrasing would be: "SPICE-HTML5 and noVNC can not be used in Internet Explorer." Line 1569: "Moreover, Websocket proxy must configured in the engine.") Line 1570: String webBasedClientsUnsupported(); Line 1571: Line 1572: @DefaultStringValue("SPICE Options") Line 1565: @DefaultStringValue("VNC") Line 1566: String vnc(); Line 1567: Line 1568: @DefaultStringValue("SPICE-HTML5 and noVNC clients can be used only in browsers other than Internet Explorer. " + Line 1569: "Moreover, Websocket proxy must configured in the engine.") :%s/"must configured"/"must be configured" Line 1570: String webBasedClientsUnsupported(); Line 1571: Line 1572: @DefaultStringValue("SPICE Options") Line 1573: String spiceOptions(); http://gerrit.ovirt.org/#/c/34836/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java: Line 55: super(myVm, parentModel); Line 56: Line 57: setTitle(ConstantsManager.getInstance().getConstants().VNCTitle()); Line 58: Line 59: boolean webSocketProxyDefined = ((ConsoleUtils) TypeResolver.getInstance().resolve(ConsoleUtils.class)).webBasedClientsSupported(); please rename also the variable to webBasedClientSupported Line 60: ClientConsoleMode desiredMode = readDefaultConsoleClientMode(); Line 61: if (desiredMode == ClientConsoleMode.NoVnc && !webSocketProxyDefined) { Line 62: desiredMode = ClientConsoleMode.Native; // fallback Line 63: } -- To view, visit http://gerrit.ovirt.org/34836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d3845a4a34bbbb703e5b9e04e7ee194071b51ca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
