Michael Kublin has posted comments on this change.
Change subject: core: avoid prms check when quota unchanged
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 370: @Override
Line 371: public void addQuotaPermissionSubject(List<PermissionSubject>
quotaPermissionList) {
Line 372: if (getStoragePool() != null &&
Line 373: getQuotaId() != null &&
Line 374:
!getStoragePool().getQuotaEnforcementType().equals(QuotaEnforcementTypeEnum.DISABLED))
{
use getVm()
Line 375: VM vm = getVmDAO().get(getVmId());
Line 376: if (vm != null && !getQuotaId().equals(vm.getQuotaId())) {
Line 377: quotaPermissionList.add(new
PermissionSubject(getQuotaId(),
Line 378: VdcObjectType.Quota,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 134: @Override
Line 135: public void addQuotaPermissionSubject(List<PermissionSubject>
quotaPermissionList) {
Line 136: if (getStoragePool() != null &&
Line 137: getQuotaId() != null &&
Line 138:
!getStoragePool().getQuotaEnforcementType().equals(QuotaEnforcementTypeEnum.DISABLED))
{
same here getVmTemplate()
Line 139: VmTemplate template =
getVmTemplateDAO().get(getVmTemplateId());
Line 140: if (template != null &&
!getQuotaId().equals(template.getQuotaId())) {
Line 141: quotaPermissionList.add(new
PermissionSubject(getQuotaId(),
Line 142: VdcObjectType.Quota,
--
To view, visit http://gerrit.ovirt.org/7180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1fe74b4d4c6f23077c70d4779265b354147259
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
