Alon Bar-Lev has posted comments on this change. Change subject: core: Adjust websockify to the new API ......................................................................
Patch Set 1: > @Alon, is there any fundamental issue with this patch? there are done comments without new push. adding multiple inheritance is something I would strongly avoided, your code you decide. no packaging nor security issues so +1 for these. well, for packaging, I would have pushed the newer websocket package into rhel so we avoid workarounds and have much cleaner code, it can be done in 3.6 cycle. -- To view, visit http://gerrit.ovirt.org/32138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
