Ravi Nori has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/35362/12/packaging/dbscripts/create_dwh_views.sql File packaging/dbscripts/create_dwh_views.sql: Line 530: surname AS last_name, Line 531: domain, Line 532: username, Line 533: department, Line 534: '' AS user_role_title, > so why does it remain? Do not want to modify the view used by DWH, might break it. If we want to remove it we need to touch DWH and better do it in a separate patch. Line 535: email, Line 536: external_id, Line 537: active, Line 538: _create_date AS create_date, http://gerrit.ovirt.org/#/c/35362/12/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1335: CREATE OR REPLACE VIEW user_vds_groups_permissions_view (entity_id, user_id) Line 1336: AS Line 1337: SELECT DISTINCT entity_id, user_id Line 1338: FROM user_vds_groups_permissions_view_base Line 1339: NATURAL JOIN engine_session_user_flat_groups; > I do not know what is natural join... but the engine_session_user_flat_grou Both user_vds_groups_permissions_view_base and engine_session_user_flat_groups are views. We are replacing the view user_flat_groups with the new engine_session_user_flat_groups view and doing a join on granted_id the column that is common between the two views. Line 1340: Line 1341: Line 1342: -- Permissions view for Data Center Line 1343: -- The user has permissions on a data center -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
