Moti Asayag has posted comments on this change. Change subject: core: filter duplicate requests to run the same vm ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36009/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java: Line 28: runVmParameters.add((RunVmParams) parameter); Line 29: } Line 30: Line 31: Set<Guid> vmIds = new HashSet<>(); Line 32: ArrayList<VdcActionParametersBase> filteredParameters = new ArrayList<>(); however changing the api of the multiple action runners from list to set ? or can it be that 2 requests for the same vm doesn't have an equal parameters instance ? such logic could be enforced on the parent command, and will ignore any duplicity, without taking care of the parameters class type ? Line 33: for (RunVmParams runVmParameter : runVmParameters) { Line 34: if (vmIds.contains(runVmParameter.getVmId())) { Line 35: continue; Line 36: } -- To view, visit http://gerrit.ovirt.org/36009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91320cfd50fc7a12b01afae2885a783c0516a6df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
