David Caro has posted comments on this change. Change subject: Adding ovirt node and ovirt node iso projects ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/36058/1/jobs/confs/shell-scripts/build-local-ovirt-node.sh File jobs/confs/shell-scripts/build-local-ovirt-node.sh: Line 1: #!/bin/bash See http://www.ovirt.org/Bash_style_guide Mainly, use spaces instead of tabs, use '[[]]' instead of '[]', use !#/bin/bash -e as shebang if possible, quote almost everything and use locales and parameters inside functions instead of global variables. Line 2: Line 3: # the die on error function Line 4: function die { Line 5: echo "$1" http://gerrit.ovirt.org/#/c/36058/1/jobs/confs/yaml/jobs/ovirt-node/rhevh_projects.yaml File jobs/confs/yaml/jobs/ovirt-node/rhevh_projects.yaml: Line 1: ############################################################################## You might want to rename the file to ovirt_node instead of rhevh Line 2: ### Projects Line 3: ############################################################################## Line 4: - project: Line 5: name: 'ovirt-node' http://gerrit.ovirt.org/#/c/36058/1/jobs/confs/yaml/scms/ovirt-node-job.yaml File jobs/confs/yaml/scms/ovirt-node-job.yaml: Line 1: ############################################################################## This file should not exist right? Line 2: ### Projects Line 3: ############################################################################## Line 4: - project: Line 5: name: 'ovirt-node' -- To view, visit http://gerrit.ovirt.org/36058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If543fe28f200e8254d4d96fa6789db3ced44f2b1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlito...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
