Arik Hadas has posted comments on this change. Change subject: engine: RFE add custom UUID for VM ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36025/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 634: getParameters().getVmStaticData().getvNumaNodeList(), getVmId()))) { Line 635: return false; Line 636: } Line 637: Line 638: if (vmFromParams.getId() != null && getVmStaticDao().get(vmFromParams.getId()) != null) { not null and not Empty guid, no? Line 639: return failCanDoAction(VdcBllMessages.VM_ID_EXISTS); Line 640: } Line 641: Line 642: return true; http://gerrit.ovirt.org/#/c/36025/2/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 202: VM_HOSTCPU_MUST_BE_PINNED_TO_HOST=Cannot ${action} ${type}. VM with host cpu flags must be pinned to host. Line 203: MIGRATION_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Migration is not supported in this CPU architecture. Line 204: MIGRATION_ON_ERROR_IS_NOT_SUPPORTED=Cannot ${action} ${type}. This resilience policy is not supported in this CPU architecture. Line 205: VM_MIGRATION_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Migration option is not supported in this CPU architecture. Line 206: VM_ID_EXISTS=VM Id already exists. how about: s/VM Id already exists./Cannot ${action} ${type}. VM with the given Id already exists in the system/g Line 207: ACTION_TYPE_FAILED_VM_CANNOT_BE_HIGHLY_AVAILABLE_AND_PINNED_TO_HOST=Cannot ${action} ${type}. A highly available VM cannot be pinned to a specific Host Line 208: ACTION_TYPE_FAILED_VM_GUID_ALREADY_EXIST=Cannot ${action} ${type}. VM with the same identifier already exists. Line 209: ACTION_TYPE_FAILED_VM_ATTACHED_TO_POOL=Cannot ${action} ${type}. VM is attached to a VM Pool. Line 210: ACTION_TYPE_FAILED_NO_AVAILABLE_POOL_VMS=Cannot ${action} ${type}. There are no available VMs in the VM-Pool. -- To view, visit http://gerrit.ovirt.org/36025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0ea7759eea35707e95ca27976c7e8d6ca4b0900 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
