Allon Mureinik has posted comments on this change. Change subject: core: Add support for copied disk template ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/35933/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 137: Guid storageDomainId) { Line 138: List<Guid> imagesContainedInStorageDomain = getImagesGuidFromStorage(storageDomainId, getStoragePoolId()); Line 139: int index = 0; Line 140: for (DiskImage templateDiskImage : copiedImagesList) { Line 141: if (storageDomainId.equals(originaTemplatelmages.get(index).getStorageIds().get(0))) { why do we depend on the order here? why not just use contains? Line 142: continue; Line 143: } Line 144: if (imagesContainedInStorageDomain.contains(templateDiskImage.getId())) { Line 145: log.info("Found a copied image of '{}' on Storage Domain id '{}'", -- To view, visit http://gerrit.ovirt.org/35933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
