Yair Zaslavsky has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/34552/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 117: try (EngineLock lock = acquireGeoRepSessionLock(updatedSession.getId())) { Line 118: GlusterVolumeEntity masterVolume = getVolumeDao().getById(updatedSession.getMasterVolumeId()); Line 119: updateGeoRepStatus(masterVolume, updatedSession); Line 120: getGeoRepDao().updateSession(updatedSession); Line 121: updateSessionDetailsInDB(updatedSession); Are you aware to the fact that if an exception is thrown (let's say un checked exception ) during the loop, the other sessions will nt be updated in db? are you ok with that? Line 122: } Line 123: } Line 124: } Line 125: Line 133: } Line 134: Line 135: Map<String, GlusterGeoRepSession> sessionsMap = getSessionsFromCLI(cluster, volumeName); Line 136: if (sessionsMap == null) { Line 137: log.debug("Error in retrieving sessions for cluster: {} from CLI, nothing to do", cluster.getName()); Why debug? if i run the app not in debug mode, it's ok i don't see anything in this case? Line 138: return; Line 139: } Line 140: Line 141: updateDiscoveredSessions(cluster, sessionsMap); http://gerrit.ovirt.org/#/c/34552/7/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 161: select fn_db_add_config_value('GlusterTaskMinWaitForCleanupInMins', '10', 'general'); Line 162: -- Gluster Geo-replication -- Line 163: select fn_db_add_config_value_for_versions_up_to('GlusterGeoReplicationEnabled', 'false', '3.5'); Line 164: select fn_db_add_config_value('GlusterRefreshRateGeoRepStatusInSecs', '300', 'general'); Line 165: select fn_db_add_config_value('GlusterRefreshRateGeoRepDiscoveryInSecs', '3600', 'general'); Please maintain alphabetical order. Line 166: Line 167: -- OpenStack related Line 168: select fn_db_add_config_value('KeystoneAuthUrl', '', 'general'); Line 169: -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
