Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: new VM: pin to host not used from template(#845570) ......................................................................
webadmin: new VM: pin to host not used from template(#845570) https://bugzilla.redhat.com/845570 New VM -> select template -> host tab The data are not read from the template. The probelem was that the reaction to the template selection change was not the read of the update of the host pinning props. Fixed by extraction of the respective logic and added to the VmModelBehaviorBase (methods doChangeDefautlHost() and updateHostPinning()). This methods are called also from the Existing* behaviours to read the respective data from the VM (or VM Data in case of Pool). This patch also enriches the AbstractVmPopupWidget by adding the listener to IsAutoAssign property, because this is not connected with the model itself. Change-Id: I561c5ee3967676ffd89758820b09a192a741a2e8 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 7 files changed, 64 insertions(+), 40 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I561c5ee3967676ffd89758820b09a192a741a2e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
