Daniel Erez has posted comments on this change.

Change subject: core: Enable Live Merge in Snapshots Overview
......................................................................


Patch Set 10:

Looks good. One last issue - upon removing disks, their status should be 
updated to 'LOCKED' (in order to avoid further operations on them), as in 
'RemoveDiskSnapshotTaskHandler -> execute' method. Could it be incorporated in 
RemoveDiskSnapshotsCommandCallback perhaps (or RemoveDiskSnapshotsCommand)?

-- 
To view, visit http://gerrit.ovirt.org/32338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to