Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix static field assignment (findbugs) in VdsBroker
......................................................................
core: Fix static field assignment (findbugs) in VdsBroker
Change-Id: Id4ad6789a4083e63572d6530bc999ef21c421975
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/35952/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
index 281998e..61ef8c2 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
@@ -87,7 +87,7 @@
@PostConstruct
private void init() {
// init the singleton. TODO remove once all code is using CDI
- instance = this;
+ setInstance(this);
log.info("Start initializing {}", getClass().getSimpleName());
List<VDS> allVdsList = DbFacade.getInstance().getVdsDao().getAll();
HashSet<Guid> nonResponsiveVdss = new HashSet<Guid>();
@@ -336,6 +336,12 @@
}
}
+ @Deprecated
+ // Remove this once ResourceManager is no longer a POJO singleton
+ private static void setInstance(ResourceManager mgr) {
+ instance = mgr;
+ }
+
/**
* Resets VM attributes
* @param vm
--
To view, visit http://gerrit.ovirt.org/35952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4ad6789a4083e63572d6530bc999ef21c421975
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
