Alon Bar-Lev has posted comments on this change. Change subject: aaa: remove user/group sync ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/35893/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java: Line 22: } Line 23: Line 24: @Override Line 25: protected void executeQueryCommand() { Line 26: getQueryReturnValue().setReturnValue(getDirectoryUser(getDbFacade().getDbUserDao().get(getParameters().getId()))); probably missing set success or set failure if there is an exception. Line 27: } Line 28: Line 29: private Collection<AuthzGroup> getDirectoryUser(DbUser dbUser) { Line 30: http://gerrit.ovirt.org/#/c/35893/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AddUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AddUserCommand.java: Line 43 Line 44 Line 45 Line 46 Line 47 please remove all isActive() handling, not required if no sync, it also effects ui I think. http://gerrit.ovirt.org/#/c/35893/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java: I probably could use the LdapGroup but: 1. I hate the Ldap name. 2. I do not wish to complete all fields. But maybe you think we should use the same. Line 1: package org.ovirt.engine.core.common.businessentities.aaa; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 4: -- To view, visit http://gerrit.ovirt.org/35893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15248a628647430d7f3d22e68e66456caffbcb40 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
