Alexander Wels has posted comments on this change. Change subject: webadmin: remove sortby/page from searchstring ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/33787/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java: Line 1255: } Line 1256: } Line 1257: Line 1258: private boolean containsTokens(String searchString, SyntaxObjectType... tokens) { Line 1259: String upperSearchString = searchString.toUpperCase(); > Is this really necessary? I'd expect the syntax checker to handle character Done Line 1260: ISyntaxChecker syntaxChecker = getAutoCompleteModel().getSyntaxChecker(); Line 1261: SyntaxContainer syntaxCont = syntaxChecker.analyzeSyntaxState(upperSearchString, true); Line 1262: Set<SyntaxObjectType> searchStringSet = new HashSet<SyntaxObjectType>(); Line 1263: Iterator<SyntaxObject> iterator = syntaxCont.iterator(); Line 1258: private boolean containsTokens(String searchString, SyntaxObjectType... tokens) { Line 1259: String upperSearchString = searchString.toUpperCase(); Line 1260: ISyntaxChecker syntaxChecker = getAutoCompleteModel().getSyntaxChecker(); Line 1261: SyntaxContainer syntaxCont = syntaxChecker.analyzeSyntaxState(upperSearchString, true); Line 1262: Set<SyntaxObjectType> searchStringSet = new HashSet<SyntaxObjectType>(); > Please consider naming this "searchStringTokenSet" or similar to imply it c Done Line 1263: Iterator<SyntaxObject> iterator = syntaxCont.iterator(); Line 1264: while(iterator.hasNext()) { Line 1265: searchStringSet.add(iterator.next().getType()); Line 1266: } Line 1264: while(iterator.hasNext()) { Line 1265: searchStringSet.add(iterator.next().getType()); Line 1266: } Line 1267: Set<SyntaxObjectType> tokenSet = new HashSet<SyntaxObjectType>(); Line 1268: tokenSet.addAll(Arrays.asList(tokens)); > The "tokens" argument will be null if user calls method like so: Done Line 1269: searchStringSet.retainAll(tokenSet); Line 1270: return !searchStringSet.isEmpty(); Line 1271: } Line 1272: -- To view, visit http://gerrit.ovirt.org/33787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b905d91e4b0a147df9c0e75c956e819ba42d0e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
