Frank Kobzik has posted comments on this change.

Change subject: core: Import/Export VM/Template with graphics dev
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35856/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java:

Line 193: 
Line 194:         GraphicsDevice graphicsDevice = null;
Line 195:         GraphicsType compatibleType = null;
Line 196: 
Line 197:         for (Pair<GraphicsType, DisplayType> graphicsDisplayPair : 
osRepository.getGraphicsAndDisplays().get(getVm().getStaticData().getOsId()).get(getVdsGroup().getcompatibility_version()))
 {
> getVdsGroup() can be null
Done
Line 198:             if 
(graphicsDisplayPair.getSecond().getDefaultVmDeviceType() == videoDeviceType) {
Line 199:                 compatibleType = graphicsDisplayPair.getFirst();
Line 200:             }
Line 201:         }


-- 
To view, visit http://gerrit.ovirt.org/35856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14f0265f9f24e09be68b500b69b3eb5ac838413
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to