Piotr Kliczewski has posted comments on this change. Change subject: rest: Validation of the protocol values ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35865/3/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java: Line 83: entity.setPort(model.getPort()); Line 84: } else { Line 85: entity.setPort(DEFAULT_VDSM_PORT); Line 86: } Line 87: if (model.isSetProtocol()) { > Here you need to do a mapping as well, can't assume that the values of VdsP Done Line 88: entity.setProtocol(VdsProtocol.fromValue(model.getProtocol())); Line 89: } Line 90: if (model.isSetSsh()) { Line 91: map(model.getSsh(), entity); -- To view, visit http://gerrit.ovirt.org/35865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
