Jiří Moskovčák has uploaded a new change for review. Change subject: don't print stacktrace when the VM is powered down while running collectors ......................................................................
don't print stacktrace when the VM is powered down while running collectors Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1170512 Change-Id: I3dd2e164d5b8a3cb23687da7ccdc66cb3e2e9fca Signed-off-by: Jiri Moskovcak <jmosk...@redhat.com> --- M mom/Monitor.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/81/35881/1 diff --git a/mom/Monitor.py b/mom/Monitor.py index 9bed82b..a4941c8 100644 --- a/mom/Monitor.py +++ b/mom/Monitor.py @@ -102,7 +102,12 @@ data[key] = val except Collector.CollectionError, e: self._disp_collection_error("Collection error: %s" % e.msg) - except Collector.FatalError, e: + # Either FatalError or any hypervisor_interface exception + # so let's be a little broad here and catch it all + # after all, it's not critical and collectors can handle + # separately whatever they want, but doesn't make sense + # to print a whole stacktrace and scare users + except Exception as e: self._set_not_ready("Fatal Collector error: %s" % e.msg) self.terminate() return None -- To view, visit http://gerrit.ovirt.org/35881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3dd2e164d5b8a3cb23687da7ccdc66cb3e2e9fca Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
