Arik Hadas has uploaded a new change for review. Change subject: core: exclude warning from findbugs ......................................................................
core: exclude warning from findbugs We intentionally write to the 'instance' field inside the 'init' method and aware the drawbacks, thus plan to change it later. Change-Id: I84e4418f8d85200ed376d347c7fab30351e47557 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/vdsbroker/exclude-filters.xml 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/35877/1 diff --git a/backend/manager/modules/vdsbroker/exclude-filters.xml b/backend/manager/modules/vdsbroker/exclude-filters.xml index 43bc332..f84b6ce 100644 --- a/backend/manager/modules/vdsbroker/exclude-filters.xml +++ b/backend/manager/modules/vdsbroker/exclude-filters.xml @@ -1,2 +1,14 @@ <FindBugsFilter> + <!-- + findbugs complains that we are writing to static field from the + non static method 'init', + The class is singleton and the init method is called on PostConstruct, + so it is safe for now and is supposed to be replaced in the future. + --> + <Match> + <Class name="org.ovirt.engine.core.vdsbroker.ResourceManager" /> + <Method name="init"/> + <Bug code="ST"/> + </Match> + </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/35877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I84e4418f8d85200ed376d347c7fab30351e47557 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
