Alex Lourie has posted comments on this change.
Change subject: packaging: Better failed start message (#838527)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
A minor comment.
....................................................
File packaging/fedora/engine-service.py
Line 297: if not os.path.exists("/proc/%d" % enginePid):
Line 298: raise Exception(
Line 299: "The engine PID file \"%s\" contains %d but "
Line 300: "that process doesn't exist. This means that "
Line 301: "the engine crashed or was killed. You will "
I suggest:
You need need to explicitly run 'service ovirt-engine stop' and then 'service
engine start' to enable it again.
Line 302: "need to explicitly run service stop and then "
Line 303: "start it again." %
Line 304: (enginePidFile, enginePid))
Line 305: else:
--
To view, visit http://gerrit.ovirt.org/7175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4099e4e32dd76eeca7f42a90e0fb5ed0049313fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
