Omer Frenkel has posted comments on this change. Change subject: core: add query for getting vms from external provider ......................................................................
Patch Set 22: (3 comments) http://gerrit.ovirt.org/#/c/33052/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java: Line 40: } Line 41: setReturnValue(vms); Line 42: } Line 43: Line 44: private VM buildVm(Map<String, Object> map) { this is the job of the vds command, it should parse the vdsm-map to a vm object and return it. probably can be done in the vdsObjectBuilder... Line 45: VM vm = new VM(); Line 46: vm.setId(Guid.createGuidFromString((String) map.get(VdsProperties.vm_guid))); Line 47: vm.setName((String) map.get(VdsProperties.vm_name)); Line 48: vm.setStatus(VMStatus.valueOf((String) map.get(VdsProperties.status))); http://gerrit.ovirt.org/#/c/33052/22/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmsFromExternalProviderParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmsFromExternalProviderParameters.java: Line 28: } Line 29: Line 30: public String getPassword() { Line 31: return password; Line 32: } please override toString method and print the parameters (without the pass..) see other vds commands parameters for example http://gerrit.ovirt.org/#/c/33052/22/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFromExternalProviderVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFromExternalProviderVDSCommand.java: Line 2: Line 3: import org.ovirt.engine.core.common.vdscommands.GetVmsFromExternalProviderParameters; Line 4: Line 5: public class GetVmsFromExternalProviderVDSCommand<T extends GetVmsFromExternalProviderParameters> extends VdsBrokerCommand<T> { Line 6: private VMListReturnForXmlRpc mVmListReturn; why not use java naming? -> vmListReturn Line 7: Line 8: public GetVmsFromExternalProviderVDSCommand(T parameters) { Line 9: super(parameters); Line 10: } -- To view, visit http://gerrit.ovirt.org/33052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I870043d8c392e6cd60d133a8701fa756b6b6a079 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
